[CodeQuality] Add negated support on SingleInArrayToCompareRector #5205
Merged
samsonasik merged 3 commits intomainfrom Oct 28, 2023
Merged
[CodeQuality] Add negated support on SingleInArrayToCompareRector #5205samsonasik merged 3 commits intomainfrom
samsonasik merged 3 commits intomainfrom
Conversation
samsonasik
commented
Oct 27, 2023
| $isIt = in_array(strtolower($type), ['$this'], true); | ||
| $isIt = in_array(strtolower($type), ['$this']); | ||
|
|
||
| $isIt = in_array(strtolower($type), ['$this', 'two']); |
Member
Author
There was a problem hiding this comment.
this skipped part for multi data moved to specific fixture
to ease discover bug in the future.
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
Author
|
@TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.